Annual Limit daily delivered & failed notification counts and seeding implementation #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added new redis_client base method to bulk update hash values by pattern
jzbahrai
reviewed
Nov 5, 2024
| """ | ||
| Resets all daily notification metrics for all services. Uses non-blocking scan_iter method to avoid locking the Redis server. | ||
| """ | ||
| pattern = notifications_key("*") # All notification keys regardless of service_id |
There was a problem hiding this comment.
can we rename this key to the annual limits notification key?
There was a problem hiding this comment.
if it is already used in places, then it is fine
- create_nightly_notification_status_for_day processes services in chunks, so we'll also atomically reset cache values in chunks too - Added doc string explaining hash structure in the annual limit client
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
5 tasks
whabanks
changed the title
jzbahrai
approved these changes
Nov 12, 2024
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary | Résumé
This PR completes the annual limit Redis client.
This will be called during
create_nightly_notification_status_for_dayto reset dailyfailedanddeliveredcounts in Redis.Related Issues | Cartes liées
Test instructions | Instructions pour tester la modification
Tests pass & integrates with API.
Release Instructions | Instructions pour le déploiement
None.
Reviewer checklist | Liste de vérification du réviseur